Repository navigation
fix(groups): use the documented membership query - #1161
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 24, 2026, 1:17 PM ET / 17:17 UTC. ClawSweeper reviewWhat this changesThe branch changes the shared membership query used by Merge readiness✅ Ready for maintainer review Keep this PR open for landing. Current main and v0.41.0 still contain the reported Cloud Identity query, and the proposed repair follows Google's documented method and the maintainer's accepted validation boundary. Priority: P2 Review scores
Verification
How this fits togetherThe Groups CLI and backup collector use the same Cloud Identity membership query for a Workspace account. Cloud Identity returns paginated memberships that become command output or backup snapshot contents. flowchart LR
A[Workspace account] --> B[Groups listing or backup]
B --> C[Shared membership query]
C --> D[Cloud Identity search]
D --> E[Paginated memberships]
E --> F[CLI output or backup snapshot]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep one documented Cloud Identity query path for both consumers, preserve provider-issued cursors, and close the linked issue after the repair merges. Do we have a high-confidence way to reproduce the issue? Yes for the request construction: current main sends the reported OR query, and the reporter supplied a comparative API result. This review did not independently repeat the call with an eligible Cloud Identity credential. Is this the best way to solve the issue? Yes. Changing the shared query helper matches Google's documented membership search and retains the existing pagination path without introducing a second request or cursor format. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c24b7dc152f0. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Landed as 1e4bb86, fixing #1059 for group listings and backups. The merged tree exactly matches reviewed/tested head 7d057e0. Validation: the new generated-client regressions fail on the original OR query and pass with Google's documented predicate; exact queries, literal escaping, pageSize=1 listings, opaque --page/--all continuation, and pageSize=1000 backup collection are covered. Full local Live-provider limitation remains explicit: both configured Workspace identities lacked delegated Groups credentials, so the original OR failure and real dynamic-group inclusion were not independently repeated. The accepted proof is the reporter's comparison, Google's method-specific contract, and request-level regressions. The maintainer relaxed the prior live gate for this bounded repair; no grants, IAM, billing, APIs, or group fixtures were changed. |
groups listand Groups backups currently send a parenthesized OR between discussion-forum and dynamic labels. The reporter demonstrated that Cloud Identity rejects that query with HTTP 400 while accepting Google's documented single-discussion-forum predicate.Use that documented predicate for both callers, preserve native pagination and output, and escape existing backslashes before apostrophes in the member literal. Google documents this filter for all direct and indirect memberships except identity-mapped groups; its dynamic-group creation example uses the same label. No second query, deduplication, or custom cursor is needed. Update the Workspace guide and Unreleased changelog; thanks @hengshan for the comparative API report.
Fixes #1059.
Validation:
Maintainer decision: accept the documented API contract plus request-level regression proof for this bounded repair, relaxing the earlier live-provider gate. No new permissions or account configuration were introduced.
Contract references: membership query, group labels, security groups, and dynamic groups.
Full local
make cipassed; the final documentation wording also passedmake docs-check. Independent P2 Auto Review completed with no actionable findings after the documentation was narrowed to the method-specific contract.